/juju

apiserver: Separate clock for pinger #6431

Merged
merged 1 commit into from Oct 12, 2016

Conversation

Reviewers

@anastasiamac anastasiamac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mjs @jujubot @anastasiamac
@mjs
Contributor

mjs commented Oct 12, 2016

Allow a separate clock to be used for the apiserver's connection ping timeout functionality. Without this it's impossible to test the ping functionality reliabily as there are a number of goroutines in the apiserver which wait on the server's clock.

If a pinger clock isn't specified, the server's main clock is used.

Likely fix for https://bugs.launchpad.net/juju/+bug/1632412

QA

Bootstrapped controller and deployed some units, then examined logs for problems or unusual activity.
@mjs
apiserver: Separate clock for pinger 
Allow a separate clock to be used for the apiserver's connection ping
timeout functionality. Without this it's impossible to test the ping
functionality reliabily as there are a number of goroutines in the
apiserver which wait on the server's clock.

If a pinger clock isn't specified the server's main clock is used.

Likely fix for https://bugs.launchpad.net/juju/+bug/1632412
4e7e1b5
@mjs
Contributor

mjs commented Oct 12, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Oct 12, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit ec6808a into juju:master Oct 12, 2016

@mjs mjs deleted the mjs:1632412-pingerSuite-reliability branch Oct 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment