Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Update lxd dependency #6439
Conversation
|
(IANAGR) LGTM, checked sha and timestamp in lxc/lxd repo. |
|
I previously ran into build issues when bumping the lxd dependencies - mgz has the detail. I would double-check that they can still build the debs with this change. |
|
I checked with balloons, he says it should be ok. $$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit 61c4b2b
into
juju:master
Oct 12, 2016
babbageclunk
deleted the
babbageclunk:lxd-leaks
branch
Oct 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
babbageclunk commentedOct 12, 2016
•
Edited 1 time
-
babbageclunk
Oct 12, 2016
This includes lxc/lxd#2480 which fixes a goroutine leak (actually 2 goroutines) anywhere we create a LXD client.
Part of http://pad.lv/1625774
QA steps:
bootstrap a LXD controller
monitor the number of goroutines running in the controller agent
I use:
Before the update, there would be 10 more goroutines for each add/destroy (read- and write-loops for 5 idle keep-alive connections).