Update lxd dependency #6439

Merged
merged 1 commit into from Oct 12, 2016

Conversation

Projects
None yet
4 participants
Member

babbageclunk commented Oct 12, 2016

This includes lxc/lxd#2480 which fixes a goroutine leak (actually 2 goroutines) anywhere we create a LXD client.

Part of http://pad.lv/1625774

QA steps:

  • bootstrap a LXD controller

  • monitor the number of goroutines running in the controller agent

    I use:

#!/bin/bash
juju ssh -m controller 0 "sudo apt install socat;
(socat tcp-listen:8080,reuseaddr,fork abstract-connect:jujud-machine-0) &
sleep 1
watch '(curl localhost:8080/debug/pprof/goroutine?debug=2 2> /dev/null) | grep \"^goroutine\" | wc -l'"
  • add a model, note goroutine increase
  • destroy the model, goroutines should go back to same level as before

Before the update, there would be 10 more goroutines for each add/destroy (read- and write-loops for 5 idle keep-alive connections).

Update lxd dependency
This includes lxc/lxd#2480 which fixes a
goroutine leak anywhere we create an LXD client.
Contributor

macgreagoir commented Oct 12, 2016

(IANAGR) LGTM, checked sha and timestamp in lxc/lxd repo.

Contributor

frobware commented Oct 12, 2016

I previously ran into build issues when bumping the lxd dependencies - mgz has the detail.

I would double-check that they can still build the debs with this change.

Member

babbageclunk commented Oct 12, 2016

I checked with balloons, he says it should be ok.

$$merge$$

Contributor

jujubot commented Oct 12, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 61c4b2b into juju:master Oct 12, 2016

@babbageclunk babbageclunk deleted the babbageclunk:lxd-leaks branch Oct 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment