Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Remove dependency on golang.org/x/sys/unix #6440
Conversation
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit 0ca9de0
into
juju:master
Oct 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
perrito666 commentedOct 12, 2016
•
Edited 1 time
-
perrito666
Oct 12, 2016
The dependency on golang.org/x/sys/unix caused issues in s390
since it requires some extra compiling steps.
This approach is not ideal but removes dependency from cgo.
The patch fixes lp:1632541, the dependency was itroduced
in 78273ef
QA steps
Compile/run tests in s390x