/juju

Corrects panics on MacOS Sierra #6455

Merged
merged 1 commit into from Oct 14, 2016

Conversation

Reviewers

@reedobrien reedobrien

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@kat-co @sinzui @jujubot @reedobrien
@kat-co
Contributor

kat-co commented Oct 14, 2016

Addresses lp:1633495.

The code was already in place, we just weren't utilizing the correct commits.
@kat-co
Corrects panics on MacOS Sierra 
Addresses lp:1633495.

The code was already in place, we just weren't utilizing the correct commits.
6a110cf
@reedobrien

reedobrien approved these changes Oct 14, 2016
View changes

LGTM

@sinzui
Contributor

sinzui commented Oct 14, 2016

LGTM
I built this on sierra and it works :). Thank you very much.
@kat-co
Contributor

kat-co commented Oct 14, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Oct 14, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju
@jujubot
Contributor

jujubot commented Oct 14, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/9511
@kat-co
Contributor

kat-co commented Oct 14, 2016

We were running into the cap on simultaneous LXD containers on the testing infrastructure.

$$merge$$
@jujubot
Contributor

jujubot commented Oct 14, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit c2a80a8 into juju:develop Oct 14, 2016
1 check failed

1 check failed

github-check-merge-juju Built PR, ran unit tests, and tested LXD deploy.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment