/juju

state: Added AllNetworkAddresses() and NetworkAddress() helpers #6467

Merged
merged 2 commits into from Oct 18, 2016

Conversation

Reviewers

@frobware frobware

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@dimitern @jujubot @frobware
@dimitern
Contributor

dimitern commented Oct 18, 2016

Machine.AllNetworkAddresses() method added, which is a simple
wrapper around the existing Machine.AllAddresses() method, but
returns a network.Address slice, more suitable for use across
the state package boundary. A related helper method added on
Address as well - NetworkAddress().

QA Steps (only unit tests):

  1. Run go test -check.v -check.f ipAddresses -cover in the
    state/ package directory.
  2. Ensure tests pass and there is no reduction of coverage
    before and after this fix.

Prerequisite to fix bug http://pad.lv/1616098.

@dimitern dimitern referenced this pull request Oct 18, 2016

Merged

api;apiserver: AllAddresses() added to SSHClient facade (v2) #6468

@dimitern
Contributor

dimitern commented Oct 18, 2016

Unrelated build failure .. again
@dimitern
Contributor

dimitern commented Oct 18, 2016

!!build!!
@dimitern
Contributor

dimitern commented Oct 18, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Oct 18, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit a438a10 into juju:develop Oct 18, 2016
1 check failed

1 check failed

github-check-merge-juju Built PR, ran unit tests, and tested LXD deploy.
Details

@dimitern dimitern deleted the dimitern:state-network-addresses branch Oct 18, 2016

jujubot added a commit that referenced this pull request Oct 19, 2016

@jujubot
Merge pull request #6468 from dimitern/api-sshclient-alladdresses 
api;apiserver: AllAddresses() added to SSHClient facade (v2)

The SSHClient API facade only has methods getting the preferred
public or private addresses of a machine/unit entity. This PR
adds a new AllAddresses() method to the facade, and bumps the
version to 2.

QA Steps (only unit tests):

  1. Run go test -check.v -cover in the api/sshclient/ and then
     in the apiserver/ package directories.
  2. Ensure tests pass and there is no reduction of coverage before
     and after this PR.

Requires (and includes!) PR #6467 - please review the state/ changes there.
Prerequisite (3/3) to fix bug http://pad.lv/1616098.
ab705af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment