/juju

OpenStack firewaller now takes a clock.Clock #6476

Merged
merged 1 commit into from Oct 19, 2016

Conversation

Reviewers

@dimitern dimitern

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@dooferlad @jujubot @dimitern
@dooferlad
Contributor

dooferlad commented Oct 19, 2016 •
Edited 1 time

This change is just to speed up testing. By taking a clock.Clock deleteSecurityGroup can be tested near-instantly rather than taking 30 seconds. The provider itself now has a clock, which is initialized by default to clock.WallClock to match the existing behavior during normal operation.

QA Steps:
This is a non-change in terms of Juju's normal usage, so just running the unit tests is sufficient.

Fixes https://bugs.launchpad.net/juju/+bug/1580626
@dooferlad
OpenStack firewaller now takes a clock.Clock 
This change is just to speed up testing. By taking a clock.Clock deleteSecurityGroup can be tested near-instantly rather than taking 30 seconds. The provider itself now has a clock, which is initialized by default to clock.WallClock to match the existing behavior during normal operation.

QA Steps:
This is a non-change in terms of Juju's normal usage, so just running the unit tests is sufficient.
75bcf6c
@dimitern

dimitern approved these changes Oct 19, 2016
View changes

Thanks! Please, assign the bug to yourself and add a comment with this PR's URL

@dooferlad
Contributor

dooferlad commented Oct 19, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Oct 19, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 1808d69 into juju:develop Oct 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment