Refactor windows userdata scripts.

[hoenirvili]

Contains modifications in the windows userdata scripts so
it can be run multiple times during provisioning without changing it's final outcome.

[perrito666]

!!build!!

[mitechie]

!!build!!

[hoenirvili]

!!build!!

[axw]

LGTM. Can you please describe what steps you took to test this? I'm presuming this is to support manual provisioning of Windows.

[hoenirvili]

@axw
The manual windows provisioning patch does not depend on this patch, but during the development I observerd this wierd behaviour.

The story of this patch come from, trying multiple times to provision the same windows machine after every juju remove-machine <number of machine>

Concicise example

juju add-machine --debug winrm:Administrator@192.168.11.11  
juju remove-machine <number-of-that-machine>

It worked, it creates the machine and fully removes it without problems, and after that I tried again with:

juju add-machine --debug winrm:Administrator@192.168.11.11

It complained that some registry keys, paths are already there, the jujud user already exist, so executing the provisioning script failes. After fixing the script now, I can provision multiple times the same machine adding and removing it without any problems.

Here's the tricky part:

Some providers don't allow to send scripts that are larger than 16 kbys so the script needs to be tested on Azure,GCE and AWS.

Azure passed, need to test this also on AWS, and GCE.

[axw]

Some providers don't allow to send scripts that are larger than 16 kbys so the script needs to be tested on Azure,GCE and AWS.

Azure passed, need to test this also on AWS, and GCE.

OK, and thanks for the details. Please let us know when this is ready to merge.

[hoenirvili]

!!build!!

[hoenirvili]

!!build!!

[hoenirvili]

$$merge$$

[jujubot]

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju