Fixes lp1634770: openstack bootstrap panics with no version specified. #6488

Merged
merged 4 commits into from Oct 23, 2016

Conversation

Projects
None yet
3 participants
Member

anastasiamac commented Oct 21, 2016

We panic on bootstrap, when openstack identity URL has no version.
For example, given cloud definition (from the bug):

nuc03-openstack:
type: openstack
auth-types: [userpass]
regions:
RegionOne:
endpoint: http://192.168.20.218:5000/

QA:

  1. Setup openstack cloud definition without version in identity URL
  2. juju bootstrap nuc03-openstack
  3. [no panic]

As a drive-by, we also check if version specified was well-formed.
Any of the variations of these following forms of identity URL should produce user-friendly message helpful to correct endpoint URL:

Member

anastasiamac commented Oct 21, 2016

$$merge$$

Contributor

jujubot commented Oct 21, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Oct 21, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/9546

Member

anastasiamac commented Oct 21, 2016

$$merge$$

Contributor

jujubot commented Oct 21, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Oct 21, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/9548

Member

anastasiamac commented Oct 23, 2016

!!build!!

Member

anastasiamac commented Oct 23, 2016

$$merge$$

Contributor

jujubot commented Oct 23, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 389b797 into juju:develop Oct 23, 2016

1 check passed

github-check-merge-juju Built PR, ran unit tests, and tested LXD deploy.
Details

@anastasiamac anastasiamac deleted the anastasiamac:openstack-version-panic-lp1634770 branch Oct 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment