provider/openstack: update goose #6501

Merged
merged 3 commits into from Oct 26, 2016

Conversation

Projects
None yet
4 participants
Member

axw commented Oct 26, 2016

Use new version of goose, to omit the device
field on volume attachment requests when no
device is specified.

This branch also uses the new OpenStack API
version discovery code in goose.

Fixes https://bugs.launchpad.net/juju/+bug/1636648

Member

axw commented Oct 26, 2016

QA

  1. bootstrap canonistack/lcy01
  2. add-machine --disks cinder,1G
@@ -381,11 +381,14 @@ func (s *cinderVolumeSource) attachVolume(arg storage.VolumeAttachmentParams) (*
return nil, err
}
}
+ if novaAttachment.Device == nil {
+ return nil, errors.Errorf("device not assigned to volume attachment")
@wallyworld

wallyworld Oct 26, 2016

Owner

test for this?

@axw

axw Oct 26, 2016

Member

Done.

provider/openstack: update goose
Use new version of goose, to omit the device
field on volume attachment requests when no
device is specified.

Fixes https://bugs.launchpad.net/juju/+bug/1636648
Member

axw commented Oct 26, 2016

$$merge$$

Contributor

jujubot commented Oct 26, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Oct 26, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/9561

Member

axw commented Oct 26, 2016

$$merge$$

Contributor

jujubot commented Oct 26, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit e9ee950 into juju:develop Oct 26, 2016

kat-co added a commit to kat-co/juju that referenced this pull request Oct 26, 2016

Merge pull request #6501 from axw/lp1636648-openstack-update-goose
provider/openstack: update goose

Use new version of goose, to omit the device
field on volume attachment requests when no
device is specified.

This branch also uses the new OpenStack API
version discovery code in goose.

Fixes https://bugs.launchpad.net/juju/+bug/1636648
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment