/juju

cmd/juju/command: Fix SSH/SCP test failures #6502

Merged
merged 1 commit into from Oct 26, 2016

Conversation

Reviewers

@axw axw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@mjs @dimitern @jujubot @axw
@mjs
Contributor

mjs commented Oct 26, 2016 •
Edited 1 time

A recent change updated the unit tests for juju ssh and juju scp in such a way that they weren't deterministic any more and frequently failed. This change limits the fake machine addresses that the tests
will use to make them deterministic and reliable again.

QA

Several hours of race stress test runs. Previously these tests would fail in a handful of iterations.
@mjs
cmd/juju/command: Fix SSH/SCP test failures 
A recent change updated the unit tests for `juju ssh` and `juju scp` in
such a way that they weren't deterministic any more and frequently
failed. This change limits the fake machine addresses that the tests
will use to make them deterministic and reliable again.
73e27cf
@axw

axw approved these changes Oct 26, 2016
View changes

@mjs
Contributor

mjs commented Oct 26, 2016

$$merge$$
@dimitern
Contributor

dimitern commented Oct 26, 2016

@mjs Thanks! And sorry for the trouble :(
@jujubot
Contributor

jujubot commented Oct 26, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 1d19099 into juju:develop Oct 26, 2016

@mjs mjs deleted the mjs:ssh-test-fixes branch Oct 26, 2016

kat-co added a commit to kat-co/juju that referenced this pull request Oct 26, 2016

@jujubot @kat-co
Merge pull request #6502 from mjs/ssh-test-fixes 
cmd/juju/command: Fix SSH/SCP test failures

A recent change updated the unit tests for `juju ssh` and `juju scp` in such a way that they weren't deterministic any more and frequently failed. This change limits the fake machine addresses that the tests
will use to make them deterministic and reliable again.

Several hours of race stress test runs. Previously these tests would fail in a handful of iterations.
b6eca99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment