/juju

Fix not_networks for MAAS 1.9 #6528

Merged
merged 2 commits into from Nov 3, 2016

Conversation

Reviewers

@dimitern dimitern

@bz2 bz2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@voidspace @bz2 @dimitern @jujubot
@voidspace

voidspace commented Nov 2, 2016

With MAAS 1.9 the not_networks parameter (for negative space constraints) should be specified as multiple values, not a comma separated list.

Fixes bug #1636969
There is a separate PR (against gomaasapi) to fix the same issue for MAAS 2.x where "not_networks" becomes "not_subnets".

QA
Bootstrap specifying negative space constraints. Juju must honour those constraints in the machine it picks.

@voidspace voidspace changed the base branch from staging to develop Nov 2, 2016

@bz2
Contributor

bz2 commented Nov 2, 2016

!!build!!
@voidspace

voidspace commented Nov 2, 2016

!!build!!
@bz2

bz2 approved these changes Nov 2, 2016
View changes

Looks good, thanks.

@dimitern
Contributor

dimitern commented Nov 2, 2016 •
Edited 1 time

LGTM and QA OK on MAAS Version 1.9.4+bzr4592-0ubuntu1 (14.04.1) - observed in /var/log/maas/maas.log during juju bootstrap with 2 negative spaces constraints:

Nov  2 13:21:35 vmaas-19 maas.api: [INFO] Request from user juju to acquire a node with constraints
 <QueryDict: {u'mem': [u'2048'], u'agent_name': [u'82119c1f-f741-49e2-8b83-626f2d375ff1'], u'arch': 
[u'amd64'], u'zone': [u'default'], u'not_networks': [u'space:2', u'space:1']}>
@voidspace

voidspace commented Nov 3, 2016

!!build!!
@voidspace

voidspace commented Nov 3, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Nov 3, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit ac4cbf5 into juju:develop Nov 3, 2016
1 check failed

1 check failed

github-check-merge-juju Built PR, ran unit tests, and tested LXD deploy.
Details

@voidspace voidspace referenced this pull request Nov 3, 2016

Merged

Fix not_networks parameter (negative space constraints) for MAAS 1.9 #6541

jujubot added a commit that referenced this pull request Nov 4, 2016

@jujubot
Merge pull request #6541 from voidspace/maas-spaces-4 
Fix not_networks parameter (negative space constraints) for MAAS 1.9

A backport of PR #6528 for juju 2.0.

With MAAS 1.9 the not_networks parameter (for negative space constraints) should be specified as multiple values, not a comma separated list.

Fixes bug #1636969
There is a separate PR (against gomaasapi) to fix the same issue for MAAS 2.x where "not_networks" becomes "not_subnets".

QA
Bootstrap specifying negative space constraints. Juju must honour those constraints in the machine it picks.
053b04f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment