/juju

Update gomaasapi #6529

Merged
merged 4 commits into from Nov 3, 2016

Conversation

Reviewers

@dimitern dimitern

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@voidspace @dimitern @jujubot
@voidspace

voidspace commented Nov 2, 2016

Fixes bug #1636919 and bug #1636969 for MAAS 2.x. Update to a newer revision of gomaasapi that replaces the incorrect not_networks parameter with the correct not_subnets (specified as multiple values instead of comma separated) for negative space constraints.

QA
Bootstrap using negative space constraints. Juju should correctly honour those constraints.
@dimitern
Contributor

dimitern commented Nov 2, 2016

LGTM and QA OK on MAAS Version 2.0.0+bzr5189-0ubuntu1 (16.04.1) - observed in /var/log/maas/maas.log during juju bootstrap with 2 negative spaces constraints:

Nov  2 13:46:11 vmaas-20 maas.api: [INFO] Request from user juju to acquire a machine with constraints
 <QueryDict: {'mem': ['2048'], 'zone': ['default'], 'arch': ['amd64'], 'agent_name': ['035e922a-5b2f-48c9-
8101-a12fada4a00f'], 'not_subnets': ['space:2', 'space:4']}>
@voidspace

voidspace commented Nov 3, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Nov 3, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@voidspace voidspace referenced this pull request Nov 3, 2016

Merged

Update gomaasapi for juju 2.0 #6537

@jujubot jujubot merged commit 6c04534 into juju:develop Nov 3, 2016
1 check passed

1 check passed

github-check-merge-juju Built PR, ran unit tests, and tested LXD deploy.
Details

jujubot added a commit that referenced this pull request Nov 3, 2016

@jujubot
Merge pull request #6537 from voidspace/maas-spaces-3 
Update gomaasapi for juju 2.0

Backport of PR #6529 

Fixes bug #1636919 and bug #1636969 for MAAS 2.x. Update to a newer revision of gomaasapi that replaces the incorrect not_networks parameter with the correct not_subnets (specified as multiple values instead of comma separated) for negative space constraints.

QA
Bootstrap using negative space constraints. Juju should correctly honour those constraints.
303dc78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment