Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Set the umask before creating directories with specified permissions #6540
Conversation
bz2
approved these changes
Nov 3, 2016
Though the umask design is mostly just a mistake, shouldn't this really defer back the original mask?
|
The umask will stay set for that process, which would only cause problems for other tests in the same suite. I think I will move it to SetUpTest so I can revert it in TearDownTest though - feels better. |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit 849d15a
into
juju:develop
Nov 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
dooferlad commentedNov 3, 2016
Set the umask before creating directories with specified permissions so the result is predictable. Fixed tests that started failing on upgrade to 16.10.