/juju

OpenStack Provider: Add IPv6 rules when setting up global group #6563

Merged
merged 1 commit into from Nov 24, 2016

Conversation

Reviewers

@axw axw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@fnordahl @mitechie @macgreagoir @axw @jujubot
@fnordahl
Member

fnordahl commented Nov 12, 2016

No description provided.

@fnordahl fnordahl changed the base branch from master to develop Nov 12, 2016

@fnordahl
Member

fnordahl commented Nov 12, 2016

retest this please

@fnordahl fnordahl changed the title from Add IPv6 rules when setting up global group to OpenStack Provider: Add IPv6 rules when setting up global group Nov 12, 2016

@mitechie
Owner

mitechie commented Nov 15, 2016

Would like to get @macgreagoir and @jameinel to peek at this please.

Thanks for the PR @fnordahl
@macgreagoir
Contributor

macgreagoir commented Nov 15, 2016

@fnordahl Thanks very much for the PR. The changes look good to me, but we will at least need one change, please. PR #6552 is due to land very soon, and introduces the use of Neutron proper, rather than the deprecated proxying via nova-network.

Can I ask you to make your changes against the new library, please? You should also be able to update the test suite for your new IPv6 rules.

Thanks again.
@fnordahl
Member

fnordahl commented Nov 15, 2016

Thank you for the feedback. That you're moving to Neutron proper is great news. I will update my PR to match the planned changes and also prepare tests.

fnordahl added a commit to fnordahl/goose that referenced this pull request Nov 23, 2016

@fnordahl
Fix Neutron test service duplicate rule check 
Current check erronously marks two rules with different RemoteIPPrefix
as duplicates.

Required by: juju/juju#6563
59109be

@fnordahl fnordahl referenced this pull request in go-goose/goose Nov 23, 2016

Merged

Fix Neutron test service duplicate rule check #32

@fnordahl
Member

fnordahl commented Nov 23, 2016

@macgreagoir New patch based on the newly merged code added. Also updated test case. Tests are currently failing due to an error in the go-goose Neutron test service. I have added PR go-goose/goose#32 to address that.

If that lands I would probably have to update this patch with correct commit position for the go-goose dependency to proceed?

jujubot added a commit to go-goose/goose that referenced this pull request Nov 23, 2016

@jujubot
Merge pull request #32 from fnordahl/fix_neutron_test_service_dup_rul… 
…e_check

Fix Neutron test service duplicate rule check

Current check erronously marks two rules with different RemoteIPPrefix
as duplicates.

Required by: juju/juju#6563
5ba7ba4
@fnordahl
Member

fnordahl commented Nov 23, 2016

Whee, the go-goose PR landed. Patch set updated with correct dependency for go-goose.
@axw

axw approved these changes Nov 24, 2016
View changes

LGTM, thanks for your contribution!

@axw
Member

axw commented Nov 24, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Nov 24, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 226ac19 into juju:develop Nov 24, 2016
1 check passed

1 check passed

github-check-merge-juju Built PR, ran unit tests, and tested LXD deploy. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details

@fnordahl fnordahl deleted the fnordahl:add_ipv6_support_to_openstack_firewaller branch Nov 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment