/juju

Change persistent-cookiejar version #6568

Merged
merged 1 commit into from Nov 15, 2016

Conversation

Reviewers

@bz2 bz2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@voidspace @jujubot @bz2
@voidspace

voidspace commented Nov 15, 2016 •
Edited 1 time

Update the version of persistent-cookiejar (and add new dependency). This changes the cookie file locking with a longer timeout and a maximum delay in the exponential back-off strategy.

Addresses issue #1632362.

QA
With multiple services with leadership, "juju status" should not hit a cookie file locked for too long error.

Full QA of the fix is unlikely until we get this into the develop PPA, however none of the semantics have changed so all existing tests should continue to pass. See: https://bugs.launchpad.net/juju-wait/+bug/1632362
@bz2

bz2 approved these changes Nov 15, 2016
View changes

Looks good.

@voidspace

voidspace commented Nov 15, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Nov 15, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju
@jujubot
Contributor

jujubot commented Nov 15, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/9654
@voidspace

voidspace commented Nov 15, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Nov 15, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit fa24945 into juju:develop Nov 15, 2016
1 check passed

1 check passed

github-check-merge-juju Built PR, ran unit tests, and tested LXD deploy. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details

@voidspace voidspace referenced this pull request Nov 15, 2016

Merged

Change persistent-cookiejar version #6571

jujubot added a commit that referenced this pull request Nov 15, 2016

@jujubot
Merge pull request #6571 from voidspace/change-cookiejar-version-2.0 
Change persistent-cookiejar version

This is the same change as PR #6568.

Update the version of persistent-cookiejar (and add new dependency). This changes the cookie file locking with a longer timeout and a maximum delay in the exponential back-off strategy.

Addresses issue #1632362.

QA
With multiple services with leadership, "juju status" should *not* hit a cookie file locked for too long error.

Full QA of the fix is unlikely until we get this into the develop PPA, however none of the semantics have changed so all existing tests should continue to pass. See: https://bugs.launchpad.net/juju-wait/+bug/1632362
b042d0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment