Change persistent-cookiejar version #6568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
added a commit
that referenced
this pull request
Nov 15, 2016
Change persistent-cookiejar version This is the same change as PR #6568. Update the version of persistent-cookiejar (and add new dependency). This changes the cookie file locking with a longer timeout and a maximum delay in the exponential back-off strategy. Addresses issue #1632362. QA With multiple services with leadership, "juju status" should *not* hit a cookie file locked for too long error. Full QA of the fix is unlikely until we get this into the develop PPA, however none of the semantics have changed so all existing tests should continue to pass. See: https://bugs.launchpad.net/juju-wait/+bug/1632362
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the version of persistent-cookiejar (and add new dependency). This changes the cookie file locking with a longer timeout and a maximum delay in the exponential back-off strategy.
Addresses issue #1632362.
QA
With multiple services with leadership, "juju status" should not hit a cookie file locked for too long error.
Full QA of the fix is unlikely until we get this into the develop PPA, however none of the semantics have changed so all existing tests should continue to pass. See: https://bugs.launchpad.net/juju-wait/+bug/1632362