Rename various CMR structs and methods #6582

Merged
merged 1 commit into from Nov 18, 2016

Conversation

Projects
None yet
3 participants
Owner

wallyworld commented Nov 18, 2016

One of a few PR's to fix the underlying CMR data model and properly name various structs and methods.

QA: bootstrap to ensure no repressions. Mechanical change only behind a feature flag.

axw approved these changes Nov 18, 2016

api/watcher/watcher.go
+// remoteRelationsWatcher will sends changes to relations an application
+// is involved in with another remote application, including changes to the
+// remote units involved in those relations, and their settings.
+type remoteRelationsWatcher struct {
commonWatcher
caller base.APICaller
applicationRelationsWatcherId string
@axw

axw Nov 18, 2016

Member

rename field?

api/watcher/watcher.go
}
-// NewApplicationRelationsWatcher returns an ApplicationRelationsWatcher which
-// communicates with the ApplicationRelationsWatcher API facade to watch
+// NewRemoteRelationsWatcher returns a RemoteRemoteRelationsWatcher which
@axw

axw Nov 18, 2016

Member

s/RemoteRemote/Remote/

api/watcher/watcher.go
-// NewApplicationRelationsWatcher returns an ApplicationRelationsWatcher which
-// communicates with the ApplicationRelationsWatcher API facade to watch
+// NewRemoteRelationsWatcher returns a RemoteRemoteRelationsWatcher which
+// communicates with the RemoteRemoteRelationsWatcher API facade to watch
@axw

axw Nov 18, 2016

Member

ditto

Owner

wallyworld commented Nov 18, 2016

$$merge$$

Contributor

jujubot commented Nov 18, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Nov 18, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/9669

Owner

wallyworld commented Nov 18, 2016

$$merge$$

Contributor

jujubot commented Nov 18, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit d9bc0bb into juju:develop Nov 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment