/juju

Clean migration collections #6587

Merged
merged 2 commits into from Nov 20, 2016

Conversation

Reviewers

@babbageclunk babbageclunk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@howbazaar @jujubot @babbageclunk
@howbazaar
Owner

howbazaar commented Nov 20, 2016

Update the comments and sections for pending migration collections.

Also updates the unhappy gofmt.
@babbageclunk

babbageclunk approved these changes Nov 20, 2016
View changes

Looks good other than a small typo.

state/migration_internal_test.go
+ // migrate that information.
+ rebootC,
+
+ // Charms as added into the migrated model during the binary transfer
@babbageclunk

babbageclunk Nov 20, 2016

Member

typo: as should be are

@howbazaar

howbazaar Nov 20, 2016

Owner

fixed

@howbazaar
Owner

howbazaar commented Nov 20, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Nov 20, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju
@jujubot
Contributor

jujubot commented Nov 20, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/9674
@howbazaar
Owner

howbazaar commented Nov 20, 2016

Another intermittent windows failure $$merge$$
@jujubot
Contributor

jujubot commented Nov 20, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 1726030 into juju:develop Nov 20, 2016
1 check failed

1 check failed

github-check-merge-juju Built PR, ran unit tests, and tested LXD deploy. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details

@howbazaar howbazaar deleted the howbazaar:clean-migration-collections branch Nov 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment