Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Add worker skeleton for cross model relations #6593
Conversation
| } | ||
| var _ = gc.Suite(&ManifoldsSuite{}) | ||
| +func (s *ManifoldsSuite) SetUpTest(c *gc.C) { | ||
| + s.SetInitialFeatureFlags(feature.CrossModelRelations) |
axw
Nov 22, 2016
Member
can you please do this in a separate test? i.e. check the standard set of manifolds, and then have another test which checks what the effect of setting the feature flag is
| +func (w *Worker) loop() error { | ||
| + for { | ||
| + // TODO(wallyworld) | ||
| + if w.killed() { |
axw
Nov 22, 2016
Member
This is going to spin in a tight loop. I think you should just bring the select up into this loop, and ditch the default case.
| +package remoterelations | ||
| + | ||
| +import ( | ||
| + "github.com/juju/errors" |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit bd8c3e2
into
juju:develop
Nov 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
wallyworld commentedNov 22, 2016
Skeleton and associated boilerplate for new remote relations worker.
QA: bootstrap lxd