dependencies.tsv: Update juju/utils on 2.0 #6602

Merged
merged 1 commit into from Dec 2, 2016

Conversation

Projects
None yet
6 participants
Contributor

bz2 commented Nov 23, 2016

Fixes lp:1468752 on 2.0 branch by bringing in new code
from utils to handle carriage returns when using gocrypto
ssh on windows clients.

Note this also brings in some other bug fixes from utils
changes that have not yet been brought to the 2.0 branch.

QA steps

  • Build and bootstrap on windows
  • juju switch controller
  • juju ssh 0
  • Run commands on the remote machine, ensure they work
Contributor

bz2 commented Nov 23, 2016

From the check script, there are build issues from minor api changes in the interveening utils commits. Investigating how invasive just adapting the code here as well is.

Member

axw commented Nov 24, 2016

Can't really review this until the breakages are fixed. We'll need to do that sooner or later, so might as well be in here.

Member

anastasiamac commented Nov 29, 2016

!!build!!

dependencies.tsv: Update juju/utils on 2.0
Fixes lp:1468752 on 2.0 branch by bringing in new code
from utils to handle carriage returns when using gocrypto
ssh on windows clients.

Note this also brings in some other bug fixes from utils
changes that have not yet been brought to the 2.0 branch.
So, fix for lp:1637079 version and HostSeries behaviour
change have also been cherrypicked back.

I don't have windows to check QA.

Also, I'd rather see the cherry picked commit and the update(s) to dependencies.tsv in separate commits -- even if in the same PR.

LGTM other than that nit.

Owner

wallyworld commented Dec 2, 2016

$$merge$$

Contributor

jujubot commented Dec 2, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit cea8c25 into juju:2.0 Dec 2, 2016

1 check passed

github-check-merge-juju Built PR, ran unit tests, and tested LXD deploy. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment