Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
dependencies.tsv: Update juju/utils on 2.0 #6602
Conversation
|
From the check script, there are build issues from minor api changes in the interveening utils commits. Investigating how invasive just adapting the code here as well is. |
anastasiamac
referenced this pull request
Nov 24, 2016
Merged
dependencies.tsv: Update juju/utils #6600
|
Can't really review this until the breakages are fixed. We'll need to do that sooner or later, so might as well be in here. |
|
!!build!! |
reedobrien
reviewed
Dec 1, 2016
I don't have windows to check QA.
Also, I'd rather see the cherry picked commit and the update(s) to dependencies.tsv in separate commits -- even if in the same PR.
LGTM other than that nit.
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit cea8c25
into
juju:2.0
Dec 2, 2016
1 check passed
github-check-merge-juju
Built PR, ran unit tests, and tested LXD deploy. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
bz2 commentedNov 23, 2016
Fixes lp:1468752 on 2.0 branch by bringing in new code
from utils to handle carriage returns when using gocrypto
ssh on windows clients.
Note this also brings in some other bug fixes from utils
changes that have not yet been brought to the 2.0 branch.
QA steps
juju switch controllerjuju ssh 0