Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
provider/maas: cater for MAAS 2.1 "bridge" types #6618
Conversation
|
!!retry!! |
voidspace
commented
Nov 25, 2016
|
LGTM |
|
!!retry!! |
|
!!retry!! |
|
LGTM, but haven't setup the QA tests yet. |
macgreagoir
approved these changes
Nov 28, 2016
QA steps tested successfully to resolve a broken bootstrap machine.
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$retry$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit 13326cf
into
juju:develop
Nov 29, 2016
1 check passed
github-check-merge-juju
Built PR, ran unit tests, and tested LXD deploy. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
frobware commentedNov 25, 2016
On MAAS 2.1 a user can now define bridges. If you do this and
bootstrap then Juju and Mongo consume lots of CPU and RAM as the
machiner repeatedly tries to add a link-layer device (to state) but
fails because linklayerdevies.type is "" (undefined).
We fix this by extending provider/maas's notion of interface types to
handle a "bridge" type. Note: this still seems brittle as we will fail
at the next interface type we don't handle.
QA steps (before applying the patch):
In MAAS 2.1 configure a node's PXE interface to be a bridge.
juju bootstrap
Look through /var/log/juju/machine-0.log for messages like:
... juju/juju/state/machine_linklayerdevices.go:641:
cannot set link-layer device addresses of machine "0"}
... juju.worker.dependency engine.go:608 restarting dependents of "machiner" manifold
... juju.worker.dependency engine.go:422 starting "machiner" manifold worker in 3.05s...
Now apply the patch and verify that (3) and (5) are golden.
Fixes LP:#1644720