Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Migrate precheck allow hook execution #6631
Conversation
howbazaar
changed the base branch from
staging
to
develop
Nov 29, 2016
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit e9cbed5
into
juju:develop
Nov 29, 2016
1 check failed
github-check-merge-juju
Built PR, ran unit tests, and tested LXD deploy. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
howbazaar commentedNov 29, 2016
Loosen up the precheck criteria to allow for hooks to be executing.
This is very important due to the workload status hook that executes every thirty seconds. Given a model of large enough size, it is reasonable to consider that there would always be some hook executing somewhere.
We do need to consider perhaps an extra precheck at a later stage to ensure that no agents are in an error state.