/juju

Change interactive add cred to use interact toolkit #6645

Merged
merged 1 commit into from Dec 15, 2016

Conversation

Reviewers

@reedobrien reedobrien

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@natefinch @reedobrien @jujubot
@natefinch
Contributor

natefinch commented Dec 1, 2016

No description provided.

@reedobrien

reedobrien approved these changes Dec 14, 2016 • edited
View changes

LGTM, so far.

cmd/juju/cloud/addcredential.go
-func (c *addCredentialCommand) readHiddenField(in io.Reader) (string, error) {
- if f, ok := in.(*os.File); ok && terminal.IsTerminal(int(f.Fd())) {
- value, err := terminal.ReadPassword(int(f.Fd()))
+func enterFile(name string, p *interact.Pollster) (string, error) {
@reedobrien

reedobrien Dec 14, 2016

Contributor

Seems like prompting for a file might be a common enough case to add to pollster. Maybe.

@reedobrien
Contributor

reedobrien commented Dec 14, 2016

!!build!!
@natefinch
Contributor

natefinch commented Dec 14, 2016

!!build!!

@natefinch natefinch changed the title from WIP: Change interactive add cred to use interact toolkit to Change interactive add cred to use interact toolkit Dec 14, 2016

@natefinch
update add-credential to use interact.Pollster
This commit was signed with a verified signature.
@natefinch natefinch Nate Finch
GPG key ID: F5F09E8A6BAA1CCA Learn about signing commits
3dc6aaa
@natefinch
Contributor

natefinch commented Dec 14, 2016

!!build!!
@natefinch
Contributor

natefinch commented Dec 15, 2016

imma try to land this as-is
$$merge$$
@jujubot
Contributor

jujubot commented Dec 15, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 2a5bb21 into juju:develop Dec 15, 2016
1 check failed

1 check failed

github-check-merge-juju Built PR, ran unit tests, and tested LXD deploy. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment