Fix intermittently-failing test #6647

Merged
merged 1 commit into from Dec 5, 2016

Conversation

Projects
None yet
3 participants
Member

babbageclunk commented Dec 2, 2016

I could make it reliable for normal runs by adjusting the delay, but running it
with the race checker made that break too, so I've relaxed the exact numbers
that it checks for. Really it just needs to check that there are
multiple messages being reported - the exact counts aren't likely to be
wrong.

Running under the stress tester with the race checker on showed no failures
in 300 runs after this change.

Fixes https://bugs.launchpad.net/juju/+bug/1646504

Fix intermittently-failing test
I could make it reliable in by adjusting the delay, but running it with
the race checker made that break too, so I've relaxed the exact numbers
that it checks for. Really it just needs to check that there are
multiple messages being reported - the exact counts are not likely to be
wrong.

Fixes https://bugs.launchpad.net/juju/+bug/1646504
Member

babbageclunk commented Dec 2, 2016

!!build!!

Member

babbageclunk commented Dec 2, 2016

$$merge$$

Contributor

jujubot commented Dec 2, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Dec 2, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/9768

Member

babbageclunk commented Dec 2, 2016

Mongo crashed on windows. :'(

Member

babbageclunk commented Dec 2, 2016

$$merge$$

Contributor

jujubot commented Dec 2, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Member

babbageclunk commented Dec 2, 2016

I don't really understand what's going on with the check build. It says trusty failed with 255, but there aren't any errors in the trusty log. It also says lxd failed - it looks like it flat-out refused to bootstrap in lxd, but I can't see anything that explains why.

Contributor

jujubot commented Dec 2, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/9772

Member

babbageclunk commented Dec 2, 2016

$$merge$$

Contributor

jujubot commented Dec 2, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Dec 2, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/9774

Member

babbageclunk commented Dec 5, 2016

$$merge$$

Contributor

jujubot commented Dec 5, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Dec 5, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/9793

Member

babbageclunk commented Dec 5, 2016

The grant check has been turned off for now - it's unreliable.

Member

babbageclunk commented Dec 5, 2016

$$merge$$

Contributor

jujubot commented Dec 5, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 6790666 into juju:develop Dec 5, 2016

1 check failed

github-check-merge-juju Built PR, ran unit tests, and tested LXD deploy. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details

@babbageclunk babbageclunk deleted the babbageclunk:fix-intermittent-progress branch Dec 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment