API client methods for pubsub message forwarding. #6659

Merged
merged 2 commits into from Dec 7, 2016

Conversation

Projects
None yet
3 participants
Owner

howbazaar commented Dec 6, 2016

Also adds the current stack to the Login userdata when in developer mode.

LGTM with a single suggestion.

api/pubsub/pubsub.go
+
+// MessageWriter returns a new message writer interface value
+// which must be closed when finished with.
+func (api *API) MessageWriter() (MessageWriter, error) {
@perrito666

perrito666 Dec 6, 2016

Contributor

I would like to have an "Open" in the name of this method so it "hints" that its something that must be closed, people might forget to otherwise.

Owner

howbazaar commented Dec 6, 2016

$$merge$$

Contributor

jujubot commented Dec 6, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Dec 6, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/9812

Owner

howbazaar commented Dec 7, 2016

$$try-again$$

Contributor

jujubot commented Dec 7, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Dec 7, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/9813

Owner

howbazaar commented Dec 7, 2016

$$now$$

Contributor

jujubot commented Dec 7, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 3cc51fd into juju:develop Dec 7, 2016

@howbazaar howbazaar deleted the howbazaar:centralhub-3-api-pubsub branch Dec 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment