Use Model Status #6661

Merged
merged 1 commit into from Dec 15, 2016

Conversation

Projects
None yet
3 participants
Contributor

natefinch commented Dec 6, 2016

This code starts us on the path to actually using status on models.
This first commit just adds code to set status, and transmit that
to juju status as needed. The only thing to currently set status
is migration, which sets status to busy, and instead of setting
its message in a special migration field, now sets the message
in the status message.

QA:
bootstrap 2 LXD providers
remove the default model on one of them
migrate the default model from one to the other.
while migrating, watch juju status --format=yaml - you should see migration status under model-status. make sure to set the watch refresh status to be short or you may miss the updates for small models.

Where there no tests to update?

apiserver/params/status.go
+ CloudRegion string `json:"region,omitempty"`
+ Version string `json:"version"`
+ AvailableVersion string `json:"available-version"`
+ ModelStatus DetailedStatus `json:"model-status,omitempty"`
@anastasiamac

anastasiamac Dec 6, 2016

Member

I am not sure you'd need 'omitempty' on a struct...

@natefinch

natefinch Dec 8, 2016

Contributor

Oops yep. :)

@natefinch natefinch changed the title from initial commit to Use Model Status Dec 7, 2016

@natefinch natefinch changed the title from Use Model Status to WIP: Use Model Status Dec 7, 2016

@natefinch natefinch changed the title from WIP: Use Model Status to Use Model Status Dec 8, 2016

Contributor

natefinch commented Dec 8, 2016

$$merge$$

Contributor

jujubot commented Dec 8, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Dec 8, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/9827

Use Model Status
This code starts us on the path to actually using status on models.
This first commit just adds code to set status, and transmit that
to juju status as needed.  The only thing to currently set status
is migration, which sets status to busy, and instead of setting
its message in a special migration field, now sets the message
in the status message.
Contributor

natefinch commented Dec 8, 2016

$$merge$$

Contributor

jujubot commented Dec 8, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Dec 8, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/9829

Contributor

natefinch commented Dec 9, 2016

$$merge$$

Contributor

jujubot commented Dec 9, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Dec 9, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/9843

Contributor

natefinch commented Dec 14, 2016

$$merge$$

Contributor

jujubot commented Dec 14, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

natefinch commented Dec 14, 2016

$$merge$$

Contributor

jujubot commented Dec 14, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/9870

Contributor

natefinch commented Dec 15, 2016

$$merge$$

Contributor

jujubot commented Dec 15, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 5c5ef8f into juju:develop Dec 15, 2016

1 check failed

github-check-merge-juju Built PR, ran unit tests, and tested LXD deploy. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment