Have the peergrouper publish the apiservers over the central hub.

[howbazaar]

Also refactors the peergrouper to use clock.Clock interface rather than time directly.

[babbageclunk]

Looks good, other than the tyop.

[babbageclunk]

pusblish

[natefinch]

If you made Publish take a simple string instead of a pubsub.Topic, you could avoid importing pubsub here (and everywhere else that defines a similar interface).

The only benefit to the Topic type is that it's already a TopicMatcher.... but all that does is prevent you from needing two subscribes - one for a single topic (the common case) and one with a matcher (less common).

If you instead wrote publish & subscribe like this:

Publish(topic string, data interface{}) (<-chan struct{}, error)
Subscribe(topic string, handler func(string, interface{})) (unsubscribe func())
SubscribeMatches(match func(string)bool, handler func(string, interface{})) (unsubscribe func())

Then things that get dependency injected wouldn't need to import pubsub at all.

Also then you wouldn't need to import pubsub when you define a topic and its types, as in the file above (messages.go)

[babbageclunk]

+1

[howbazaar]

$$merge$$

[jujubot]

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

[jujubot]

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/9834

[howbazaar]

$$merge$$

[jujubot]

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju