/juju

Stop using pkg/errors in juju code #6670

Merged
merged 1 commit into from Dec 9, 2016

Conversation

Reviewers

@bz2 bz2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@natefinch @voidspace @jujubot @bz2
@natefinch
Contributor

natefinch commented Dec 7, 2016

goimports betrayed me

QA: run go test in cmd/juju/cloud
@natefinch
Stop using pkg/errors in juju code
This commit was signed with a verified signature.
@natefinch natefinch Nate Finch
GPG key ID: F5F09E8A6BAA1CCA Learn about signing commits
53e63fb
@voidspace

voidspace commented Dec 7, 2016

LGTM
@bz2

bz2 approved these changes Dec 7, 2016
View changes

LGTM.

@natefinch
Contributor

natefinch commented Dec 7, 2016

Note that due to transitive dependencies, this is still required in dependencies.tsv, but juju code itself should not be using it.
@natefinch
Contributor

natefinch commented Dec 7, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Dec 7, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju
@jujubot
Contributor

jujubot commented Dec 7, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/9821
@natefinch
Contributor

natefinch commented Dec 9, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Dec 9, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit ff78c96 into juju:develop Dec 9, 2016
1 check passed

1 check passed

github-check-merge-juju Built PR, ran unit tests, and tested LXD deploy. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment