/juju

Remove zfs usage in Xenial #6684

Merged
merged 1 commit into from Dec 9, 2016
+10 −40

Conversation

Reviewers

@bz2 bz2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@natefinch @jujubot @bz2
@natefinch
Contributor

natefinch commented Dec 9, 2016

Fixes https://bugs.launchpad.net/juju/+bug/1648513
@natefinch
Remove zfs usage in Xenial 
Fixes https://bugs.launchpad.net/juju/+bug/1648513
This commit was signed with a verified signature.
@natefinch natefinch Nate Finch
GPG key ID: F5F09E8A6BAA1CCA Learn about signing commits
8186249
@bz2

bz2 approved these changes Dec 9, 2016
View changes

Thanks! Let's try in in CI.

container/lxd/initialisation_linux.go
-var xenialPackages = []string{
- "zfsutils-linux",
-}
+var xenialPackages = []string{}
@bz2

bz2 Dec 9, 2016

Contributor

Remove this var and the loop over it in ensureDependencies()?

container/lxd/initialisation_linux.go
@@ -68,7 +64,14 @@ func (ci *containerInitialiser) Initialise() error {
// Well... this will need to change soon once we are passed 17.04 as who
// knows what the series name will be.
if ci.series >= "xenial" {
@bz2

bz2 Dec 9, 2016

Contributor

One query is whether skipping lxd init on older series is still correct.

@natefinch

natefinch Dec 9, 2016 •
Edited 1 time

Contributor

¯\(ツ)/¯

@natefinch
Contributor

natefinch commented Dec 9, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Dec 9, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 9f5aa1f into juju:2.1 Dec 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment