Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
migrations: don't start model workers while a model is importing #6700
Conversation
babbageclunk
added some commits
Dec 8, 2016
|
Doesn't need rereview - no difference between this and #6678. |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
Failed to bootstrap on lxd. ): $$retry$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
Windows tests failed for something to do with Mongo: $$retry$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit 8a03fbc
into
juju:develop
Dec 14, 2016
1 check passed
babbageclunk
deleted the
babbageclunk:migration-bounce
branch
Dec 14, 2016
|
Yay! |
babbageclunk commentedDec 13, 2016
Fixes https://bugs.launchpad.net/juju/+bug/1646310
(Recreated for develop branch from #6678.)
Starting the migration master while the model was being imported back
into a controller that it had previously migrated out of caused it to
uninstall itself from the engine (thinking that it was finished
processing the old migration), which blocked any workers that depended
on
ifNotMigrating. To fix this we wait until the modelMigrationModehas changed to
MigrationModeNone- this means the watcher needs tosignal on any changes to models, rather than just life.
Add a global flag to the
collectionWatcherconfig - this lets the watcher returnids for any model, rather than just the current one.
The apiserver code to remove state objects from the pool still needs to
watch life specifically. If the model becomes
Deadand is thenremoved within the event coalescence time then the collection watcher
won't report any event, but a lifecycle watcher will.
QA steps: