Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Handle when one of the subnets is unknown. #6721
Conversation
|
!!build!! |
|
!!build!! |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit f84f05a
into
juju:develop
Dec 20, 2016
1 check passed
github-check-merge-juju
Built PR, ran unit tests, and tested LXD deploy. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
jameinel
deleted the
jameinel:host-spaces-with-extra-addresses
branch
Apr 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
jameinel commentedDec 15, 2016
It seems that address.Subnet() can fail with NotFound but this should be handled as an expected condition. (I audited the other call sites for Subnet() and they all handle the NotFoundError.)
So we just need to also do this in LinkLayerDevicesForSpaces().
Added a test, I will merge this into my other branch and verify it fixes the current problem.