Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Send discharged macaroons when connecting to a stream #6742
Conversation
|
QA steps:
|
|
!!chittychitty!! |
babbageclunk
changed the title from
Send discharged macaroons when connecting to a strean
to
Send discharged macaroons when connecting to a stream
Dec 22, 2016
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
babbageclunk
referenced this pull request
Dec 22, 2016
Merged
Send discharged macaroons when connecting to a stream (forward port) #6747
jujubot
merged commit 741d0cf
into
juju:2.1
Dec 22, 2016
added a commit
that referenced
this pull request
Dec 22, 2016
babbageclunk
deleted the
babbageclunk:mm-logtransfer-macaroons
branch
Dec 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
babbageclunk commentedDec 22, 2016
If the macaroons passed in to an API client connection already include
discharge macaroons, the discharge request dance doesn't need to be
done, so the macaroons won't be in the cookie jar. In this case make
sure they're still sent along when making a websocket connection. (This
is analogous to the code in api.state.Login that adds macaroons from the
bakery client jar to the login request.)
Includes a drive-by fix to MacaroonSuite - the DischargerLogin function
wasn't reset in setup so the function set in one test could be called
accidentally from another test.
Fixes https://bugs.launchpad.net/juju/+bug/1650451