Include icon in RemoteApplicationInfo result #6766

Merged
merged 1 commit into from Jan 5, 2017

Conversation

Projects
None yet
3 participants
Owner

wallyworld commented Jan 5, 2017

The RemoteApplicationInfo api now includes the icon for remote apps from another model in the same controller.

Some code in apiserver/charms was refactored to extract common functionality that is now used by both the charm http handler as well as the application facade. A drive by fix was also done to better locate a helper newStorage method in the file which uses it.

QA: bootstrap and check GUI renders correctly.

Looks good to me.

Owner

wallyworld commented Jan 5, 2017

$$merge$$

Contributor

jujubot commented Jan 5, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Jan 5, 2017

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/9953

Owner

wallyworld commented Jan 5, 2017

$$merge$$

Contributor

jujubot commented Jan 5, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Jan 5, 2017

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/9955

Owner

wallyworld commented Jan 5, 2017

$$merge$$

Contributor

jujubot commented Jan 5, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 805d59a into juju:develop Jan 5, 2017

1 check failed

github-check-merge-juju Built PR, ran unit tests, and tested LXD deploy. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment