/juju

lp:1654589 -- broken 390x build #6777

Merged
merged 1 commit into from Jan 6, 2017

Conversation

Reviewers

@natefinch natefinch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@reedobrien @jujubot @natefinch
@reedobrien
Contributor

reedobrien commented Jan 6, 2017

Since we only support kvm on arm64, amd64, and pp64el, it seems ideal
to not biuld it elsewhere. However, why punish others where it might
just work.

Is it better to not build and explicitly state it isn't
supported on other arches or to let it build and then maybe not work?

Fixes: https://bugs.launchpad.net/bugs/1654589
@reedobrien
Don't be specific about architectures to build 
Since we only support kvm on arm64, amd64, and pp64el, it seems ideal
to not biuld it elsewhere. However, why punish others where it might
just work.

Is it better to not build and explicitly state it isn't
supported on other arches or to let it build and then maybe not work?

Fixes: https://bugs.launchpad.net/bugs/1654589
627ca77
@natefinch

natefinch approved these changes Jan 6, 2017
View changes

lgtm

@reedobrien
Contributor

reedobrien commented Jan 6, 2017

$$merge$$
@jujubot
Contributor

jujubot commented Jan 6, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit e0c8791 into juju:develop Jan 6, 2017

@reedobrien reedobrien deleted the reedobrien:lp/1654589_broke-390x-build branch Jan 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment