Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
migrations: Add AdoptInstances to lxd provider #6827
Conversation
babbageclunk
added some commits
Jan 17, 2017
|
!!chittychitty!! |
| @@ -123,3 +123,22 @@ func (env *environ) parsePlacement(placement string) (*instPlacement, error) { | ||
| return nil, errors.Errorf("unknown placement directive: %v", placement) | ||
| } | ||
| + | ||
| +// MoveInstancesToController updates the controller tags on the |
axw
Jan 18, 2017
Member
MoveInstancesToController is a bit of a mouthful. How about "AdoptInstances", to keep it brief?
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
Seems spurious - it's lxd failing to bootstrap, but I can bootstrap locally fine. |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
babbageclunk
changed the title from
migrations: Add MoveInstancesToController to lxd provider
to
migrations: Add AdoptInstances to lxd provider
Jan 18, 2017
jujubot
merged commit e5fed33
into
juju:2.1
Jan 18, 2017
1 check failed
github-check-merge-juju
Built PR, ran unit tests, and tested LXD deploy. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
babbageclunk commentedJan 18, 2017
•
Edited 1 time
-
babbageclunk
Jan 18, 2017
Part of https://bugs.launchpad.net/juju/+bug/1648063
Implement AdoptInstances in the lxd provider using client.SetContainerConfig.
QA steps - none, this code isn't runnable until the migration master is updated.