Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Change location of the meter status worker state file. #6843
Conversation
|
@howbazaar - we don't really need to move the old file - an upgrade happening implies that the agent has connectivity, so it will receive an update soon enough. I could add an upgrade step that removes the old file, though. |
|
!!build!! |
|
QA steps: Deploy a charm with this version of Juju. ssh into unit. Confirm that meter-status.yaml file is in Deploy a metered charm with Juju release prior to this fix. upgrade-juju to a release containing this fix. Confirm same results as above. |
|
@howbazaar - PTAL |
|
Pinging @howbazaar for another look... |
| @@ -36,6 +36,16 @@ func stepsFor20() []Step { | ||
| targets: []Target{Controller}, | ||
| run: removeCharmGetCache, | ||
| }, | ||
| + &upgradeStep{ |
howbazaar
Feb 20, 2017
Owner
These upgrade steps are in the wrong place. There should be some for 2.2. These are for 2.0.
|
@howbazaar - updated, thanks for the review! |
|
@howbazaar - could you take a look at this? |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
!!build!! |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
tasdomas commentedJan 20, 2017
The meter status worker keeps a local file to cache the currently known value of meter status in case connection to the controller is lost. This PR changes the location of that state file, moving it to the agent directory.