/juju

Fix pre-push failures #6863

Merged
merged 3 commits into from Jan 24, 2017

Conversation

Reviewers

@howbazaar howbazaar

@wallyworld wallyworld

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@reedobrien @jujubot @howbazaar @wallyworld
@reedobrien
Contributor

reedobrien commented Jan 24, 2017

Please provide the following details to expedite Pull Request review:

Description of change

Why is this change needed?

The pre push hook fails due to gofmt, build, and check testing failures.

QA steps

How do we verify that the change works?

Try pushing with pre-push hook enabled.

Documentation changes

Does it affect current user workflow? CLI? API?

N/A

Bug reference

Does this change fix a bug? Please add a link to it.
N/A

reedobrien added some commits Jan 24, 2017

@reedobrien
Make gofmt happy 
Someone appears to not have gofmt enabled in their browser.
Additionally, it appears they don't have the precommit hook enabled.
Finally, it seems that our CI pipeline doesn't check gofmt.
e8ff4c0
@reedobrien
Correct a call to Infof which fails to build
071d73a
@reedobrien
Fix import alias to match the checktesting script
eb172dc
@reedobrien
Contributor

reedobrien commented Jan 24, 2017

$$merge$$
@jujubot
Contributor

jujubot commented Jan 24, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju
@jujubot
Contributor

jujubot commented Jan 24, 2017

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/10100

@jujubot jujubot merged commit 8ad1343 into juju:develop Jan 24, 2017

@reedobrien reedobrien deleted the reedobrien:fix/prepush-failures branch Jan 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment