Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Move builtin clouds to providers #6869
Conversation
| @@ -248,8 +249,8 @@ func (c *bootstrapCommand) Init(args []string) (err error) { | ||
| // BootstrapInterface provides bootstrap functionality that Run calls to support cleaner testing. | ||
| type BootstrapInterface interface { | ||
| Bootstrap(ctx environs.BootstrapContext, environ environs.Environ, args bootstrap.BootstrapParams) error | ||
| + CloudDetector(environs.EnvironProvider) (environs.CloudDetector, bool) |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Generating tarball failed |
|
$$derp$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit 1b100d9
into
juju:develop
Jan 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
axw commentedJan 25, 2017
Description of change
Remove the builtin cloud definitions from
the cloud package, and add an interface
that providers can implement to "detect"
clouds. For now this is just implemented
by LXD to return the localhost cloud, but
it could also be used to detect cloud
definitions based on client-side config
such as novarc files, etc.
Also, finalize detected credentials.
These changes will be used in a followup
to have the localhost cloud definition include
the LXD host address included in the cloud
endpoint; and injecting credentials via
cloud credentials, rather than by injecting
files into the containers via cloud-init.
QA steps
Documentation changes
No functional changes.
Does it affect current user workflow? CLI? API?
Bug reference
This PR does not fix any bugs. A followup will be made to fix https://bugs.launchpad.net/juju/+bug/1633788.