Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Make juju run on machines use the ubuntu user #6873
Conversation
howbazaar
added some commits
Jan 25, 2017
| @@ -40,6 +43,7 @@ func HandleAction(name string, params map[string]interface{}) (results map[strin | ||
| func handleJujuRunAction(params map[string]interface{}) (results map[string]interface{}, err error) { | ||
| // The spec checks that the parameters are available so we don't need to check again here | ||
| command, _ := params["command"].(string) | ||
| + logger.Debugf("juju run %q", command) |
mjs
Jan 26, 2017
Contributor
Maybe trace?
And what about potentially sensitive things on the command line?
howbazaar
Jan 26, 2017
Owner
OK, I can live with trace. Standard practice is to not put sensitive things on the command line :) As that stuff goes into history files.
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$windows-mongo-suckage$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit 07102c0
into
juju:2.1
Jan 26, 2017
1 check failed
github-check-merge-juju
Built PR, ran unit tests, and tested LXD deploy. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
howbazaar commentedJan 26, 2017
With the 2.0 change to how 'juju run' was processed to use the actions infrastructure rather than ssh from the controllers, the machine execution changed from running using the ubuntu user to being executed as root without some login environment variables processed.
QA steps
$ juju run --machine 0 env
$ juju run --machine 0 juju-goroutines
Bug reference
Fixes lp:1655124