Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Add extra-info as official string config value for models. #6874
Conversation
babbageclunk
approved these changes
Jan 26, 2017
This seems good to me. I'm not sure about making it a string though - wouldn't a map[string]interface{} be a bit more future-proof? Is it just the complexity?
|
We have "annotations" on applications for things like GUI and deployer to store their extra information. I wonder if calling it something similar would help. |
|
@jameinel we have no CLI way of setting or getting annotations. I do think that perhaps that would be the future way of doing things where we namespace more. |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Generating tarball failed |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
howbazaar commentedJan 26, 2017
This work adds a model config value 'extra-info' as an official string value to allow users to store arbitrary data against a model. This has been requested by conjure-up.
QA steps
$ juju model-config extra-info="---\nname: this is more yaml\n"
$ juju model-config extra-info
'---\nname: this is more yaml\n'
Bug reference
Fixes lp:1659444.