/juju

worker/machiner: rewrite tests as unit tests #6892

Merged
merged 1 commit into from Feb 1, 2017

Conversation

Reviewers

@wallyworld wallyworld

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@axw @reedobrien @jujubot @wallyworld
@axw
Member

axw commented Jan 31, 2017 •
Edited 1 time

Rewrite the existing worker/machiner JujuConnSuite
tests to be unit tests. There's still some patching
going on as there was before, but there is no longer
any interaction with Mongo.

This should fix some intermittent CI test failures. It
also cuts down the test time. The tests for this package
now run in less than a second on my laptop, whereas
they were taking 7-11s before.

Fixes: https://bugs.launchpad.net/juju/+bug/1659011
@axw
worker/machiner: rewrite tests as unit tests 
Rewrite the existing worker/machiner JujuConnSuite
tests to be unit tests. There's still some patching
going on as there was before, but there is no longer
any interaction with Mongo.
2ccf360
@reedobrien
Contributor

reedobrien commented Jan 31, 2017

w00t
@axw
Member

axw commented Jan 31, 2017

!!bangbang!!
@axw
Member

axw commented Feb 1, 2017

!!banghello?bang!!
@axw
Member

axw commented Feb 1, 2017

$$merge$$
@jujubot
Contributor

jujubot commented Feb 1, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 81023ab into juju:2.1 Feb 1, 2017
1 check passed

1 check passed

github-check-merge-juju Built PR, ran unit tests, and tested LXD deploy. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment