Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
2.1 containerizer config 1657449 #6898
Conversation
jameinel
added some commits
Jan 31, 2017
frobware
approved these changes
Feb 1, 2017
I tried this on Azure, GCE and AWS. I got a container on each with the lxc config showing lxdbr0 for the parent device.
| -func (ctx *hostChangesContext) ProcessOneContainer(netEnv environs.NetworkingEnviron, idx int, host, container *state.Machine) error { | ||
| - netBondReconfigureDelay := netEnv.Config().NetBondReconfigureDelay() | ||
| +func (ctx *hostChangesContext) ProcessOneContainer(env environs.Environ, idx int, host, container *state.Machine) error { | ||
| + netBondReconfigureDelay := env.Config().NetBondReconfigureDelay() | ||
| bridgePolicy := containerizer.BridgePolicy{ | ||
| NetBondReconfigureDelay: netBondReconfigureDelay, |
|
$$merge$$ |
jameinel
changed the title from
WIP: 2.1 containerizer config 1657449
to
2.1 containerizer config 1657449
Feb 1, 2017
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$merge$$ the error just says "exit code 255" which i don't see a cause |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Does not match ['fixes-1660877'] |
|
JFDI |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jameinel commentedFeb 1, 2017
Description of change
Along with my change to always record all host machine devices, this should enable the original "lxdbr0" functionality that we had in 2.0.
This adds a method on Environments (providers) that we can introspect to see if we think bridging to the host device will be useful. When we would be unable to allocate a Provider level IP address for the containers, we fall back to doing DHCP on the 'lxdbr0' bridge for that container.
QA steps
You should end up with a container that has a valid (if local) IP address (most likely 10.0.0.*).
Bug reference
https://pad.lv/1657449