Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
provider/lxd: handle concurrent AddCert #6912
Conversation
|
$$fixes-1661458$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit 2824243
into
juju:2.1
Feb 3, 2017
added a commit
that referenced
this pull request
Feb 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
axw commentedFeb 3, 2017
Description of change
Fix a TOCTOU bug, where we check if the
certificate exists on the server and then
add it if it's not there. We must make
a second check if the update fails, to
see if there was a concurrent add.
QA steps
How do we verify that the change works?
lxc config trust list | grep '|' | grep -v FINGERPRINT | cut -d'|' -f2 | awk '{print $1}' | xargs -L1 lxc config trust removeDocumentation changes
None.
Bug reference
Fixes https://bugs.launchpad.net/juju/+bug/1661458