Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Add missing GCE regions #6935
Conversation
|
!!build!! |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
Waiting for QA tests on the fallback-public-cloud.yaml file to complete. Should be done tomorrow afternoon. |
|
Shouldn't it be possible for you to test this just by doing "juju bootstrap gce/$REGION" ? (especially if its using a version string that means it will use a local agent.) Also, last comment from 2 days ago says that it will be done "tomorrow" which is now "yesterday". :) |
|
I did. They worked. However, AFAIU QA blocks landing on changes to fallback-public-clouds.yaml as that is what gets signed and uploaded. It turns out there is a problem with aws ap-northeast-2 which is unrelated to this PR, but QA doesn't want to sign and publish an updated public-clouds.yaml due to that issue. I tried a quick removal of ap-northeast-2 since it is broken, figuring we could fix it and put it back once fixed. That ran into other opposition, however. And so yesterday turned into today... I am looking at fixing https://bugs.launchpad.net/juju/+bug/166304 currently. |
|
Just so you're aware, we consider the ap-northeast-2 bug a problem until there is a juju release (not a beta or rc) that supports ap-northeast-2. As such, I am updating streams.canonical.com to add the GCE regions and remove ap-northeast-2. Here's the unsigned version I will be using. https://bazaar.launchpad.net/~canonical-juju-qa/+junk/clouds-unsigned/view/15/clouds.yaml |
|
BTW @jameinel just bootstrapping is not sufficient. The ap-northeast-2 bug is only evident when we deploy. |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
reedobrien commentedFeb 7, 2017
Description of change
This PR adds the US West and Asia Northeast regions to GCE.
Why is this change needed?
Because they are newish and missing.
QA steps
How do we verify that the change works?
Get validation from QA
Documentation changes
N/A
Does it affect current user workflow? CLI? API?
No
Bug reference
https://bugs.launchpad.net/juju/+bug/1662449