Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
migrations: Call AdoptResources from migrationmaster worker #6952
Conversation
babbageclunk
added some commits
Feb 9, 2017
| // There's no turning back from SUCCESS - any problems should have | ||
| // been picked up in VALIDATION. After the minion wait in the | ||
| // SUCCESS phase, the migration can only proceed to LOGTRANSFER. | ||
| return coremigration.LOGTRANSFER, nil | ||
| } | ||
| +func (w *Worker) transferResources(targetInfo coremigration.TargetInfo, modelUUID string) error { | ||
| + w.setInfoStatus("transferring cloud resources to target controller") |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Thanks @axw |
|
Build failed: Tests failed |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit 2f970c3
into
juju:2.1
Feb 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
babbageclunk commentedFeb 9, 2017
Description of change
Once the migration is successful we call AdoptResources on the target controller to mark all of the resources used by the model as managed by the target controller. This prevents the source controller from incorrectly cleaning those resources up if it's destroyed.
Which resources are transferred depends on the cloud hosting the model, but it generally includes things like instances, volumes, and security groups.
QA steps
(Should be done for all clouds, but especially ec2, gce, azure, rackspace, maas, lxd and openstack, since they handle resource tagging and cleanup when a controller is destroyed.)
Bug reference
Fixes https://bugs.launchpad.net/juju/+bug/1648063