Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Add skipflaky flag to unit tests, skip initial worst offenders for intermittency #6956
Conversation
nskaggs
added some commits
Feb 9, 2017
nskaggs
changed the base branch from
staging
to
2.1
Feb 9, 2017
|
!!checkme!! |
|
!!build!! |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit 6463f3a
into
juju:2.1
Feb 9, 2017
1 check failed
github-check-merge-juju
Built PR, ran unit tests, and tested LXD deploy. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
nskaggs commentedFeb 9, 2017
Description of change
This change adds a new flag for use with intermittent test failures. Once CI has identified an intermittent failure, which is not otherwise able to be fixed at the present time, the flag can be added to the testcase in order to skip it.
This change is needed to ensure the CI test results are actionable and consistent. You are encourage to use the arch specific skips as needed (as I have done on a few below, for example, skipping only on windows).
QA steps
Build and run the unit tests. Ensure the skipped tests indeed show as skips.
Documentation changes
None.
Bug reference
The skipped tests all contain links to bug numbers, which link to CI issues. They can be used to fix the tests and remove the skips.