Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Add skip flaky develop #6957
Conversation
nskaggs
added some commits
Feb 9, 2017
reedobrien
approved these changes
Feb 9, 2017
LGTM.
I'd be a little worried that once they're skipped no one will ever look at them again. Some of those lp issues look to be pretty old though so....
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
jujubot
merged commit 0a075d8
into
juju:develop
Feb 9, 2017
1 check failed
github-check-merge-juju
Built PR, ran unit tests, and tested LXD deploy. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
nskaggs commentedFeb 9, 2017
Description of change
This change adds a new flag for use with intermittent test failures. Once CI has identified an intermittent failure, which is not otherwise able to be fixed at the present time, the flag can be added to the testcase in order to skip it.
This change is needed to ensure the CI test results are actionable and consistent. You are encourage to use the arch specific skips as needed (as I have done on a few below, for example, skipping only on windows).
QA steps
Build and run the unit tests. Ensure the skipped tests indeed show as skips.
Documentation changes
None.
Bug reference
The skipped tests all contain links to bug numbers, which link to CI issues. They can be used to fix the tests and remove the skips.