/juju

Fix juju ssh/scp --proxy without model selected #6977

Merged
merged 1 commit into from Feb 14, 2017

Conversation

Reviewers

@babbageclunk babbageclunk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mjs @jujubot @babbageclunk
@mjs
Contributor

mjs commented Feb 14, 2017

Description of change

The command line generated when --proxy is now specifies the selected model. This ensures that juju ssh/scp --proxy works when there's no model in focus (but --model is used).

Fixes https://bugs.launchpad.net/juju/2.1/+bug/1662732

QA steps

Confirmed that the steps in the bug report now work.

Documentation changes

No documentation changes required.

Bug reference

https://bugs.launchpad.net/juju/2.1/+bug/1662732
@mjs
Fix juju ssh/scp --proxy without model selected 
The command line generated when --proxy is now specifies the selected
model. This ensures that juju ssh/scp --proxy works when there's no
model focus (but --model is used).

Fixes https://bugs.launchpad.net/juju/2.1/+bug/1662732
a69c18c
@babbageclunk

babbageclunk approved these changes Feb 14, 2017
View changes

Nice.

@mjs
Contributor

mjs commented Feb 14, 2017

$$merge$$
@jujubot
Contributor

jujubot commented Feb 14, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit e7062a1 into juju:2.1 Feb 14, 2017

@mjs mjs deleted the mjs:1662732-ssh-proxy-no-model-selected branch Feb 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment