Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the gabriel-samfira/sys fork #6987

Merged
merged 1 commit into from Feb 15, 2017

Conversation

axw
Copy link
Contributor

@axw axw commented Feb 15, 2017

Description of change

Not needed any more, since we're no longer
tied to Go 1.2.

QA steps

  • Run the unit tests.
  • Build the windows client and agent.

Documentation changes

None.

Bug reference

Fixes https://bugs.launchpad.net/juju/+bug/1470820

@axw
Copy link
Contributor Author

axw commented Feb 15, 2017

$$merge$$

@jujubot
Copy link
Collaborator

jujubot commented Feb 15, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot
Copy link
Collaborator

jujubot commented Feb 15, 2017

Build failed: Generating tarball failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/10295

@anastasiamac
Copy link
Contributor

@axw
Build failed because:
gofmt is sad:
cmd/jujud/main_windows.go
service/windows/service_windows_test.go
service/windows/service_windows.go
service/windows/stubwinsvc_test.go

  • EXIT_STATUS=1

@axw
Copy link
Contributor Author

axw commented Feb 15, 2017

Oops, just a simple sed command it was not.

@axw axw force-pushed the lp1470820-drop-gsamfira-sys-fork branch from 2cbaf6b to 9e6e367 Compare February 15, 2017 09:11
@axw
Copy link
Contributor Author

axw commented Feb 15, 2017

$$merge$$

@jujubot
Copy link
Collaborator

jujubot commented Feb 15, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot
Copy link
Collaborator

jujubot commented Feb 15, 2017

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/10296

@axw
Copy link
Contributor Author

axw commented Feb 15, 2017

$$oncemoreforgoodluck$$

@jujubot
Copy link
Collaborator

jujubot commented Feb 15, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot
Copy link
Collaborator

jujubot commented Feb 15, 2017

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/10299

@anastasiamac
Copy link
Contributor

From windows log:
cannot find package "golang.org/x/sys/windows/registry" in any of:
C:\Go\src\golang.org\x\sys\windows\registry (from $GOROOT)
c:\users\admini~1\appdata\local\temp\tmpmpw_zd\gogo\src\golang.org\x\sys\windows\registry (from $GOPATH)

Not needed any more, since we're no longer
tied to Go 1.2.

Fixes https://bugs.launchpad.net/juju/+bug/1470820
@axw axw force-pushed the lp1470820-drop-gsamfira-sys-fork branch from 9e6e367 to 70dc71d Compare February 15, 2017 12:19
@axw
Copy link
Contributor Author

axw commented Feb 15, 2017

$$merge$$

@jujubot
Copy link
Collaborator

jujubot commented Feb 15, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 944bc28 into juju:2.1 Feb 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants