Drop the gabriel-samfira/sys fork #6987

Merged
merged 1 commit into from Feb 15, 2017

Conversation

Projects
None yet
4 participants
Member

axw commented Feb 15, 2017

Description of change

Not needed any more, since we're no longer
tied to Go 1.2.

QA steps

  • Run the unit tests.
  • Build the windows client and agent.

Documentation changes

None.

Bug reference

Fixes https://bugs.launchpad.net/juju/+bug/1470820

Member

axw commented Feb 15, 2017

$$merge$$

Contributor

jujubot commented Feb 15, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Feb 15, 2017

Build failed: Generating tarball failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/10295

Member

anastasiamac commented Feb 15, 2017

@axw
Build failed because:
gofmt is sad:
cmd/jujud/main_windows.go
service/windows/service_windows_test.go
service/windows/service_windows.go
service/windows/stubwinsvc_test.go

  • EXIT_STATUS=1
Member

axw commented Feb 15, 2017

Oops, just a simple sed command it was not.

Member

axw commented Feb 15, 2017

$$merge$$

Contributor

jujubot commented Feb 15, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Feb 15, 2017

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/10296

Member

axw commented Feb 15, 2017

$$oncemoreforgoodluck$$

Contributor

jujubot commented Feb 15, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Feb 15, 2017

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/10299

Member

anastasiamac commented Feb 15, 2017

From windows log:
cannot find package "golang.org/x/sys/windows/registry" in any of:
C:\Go\src\golang.org\x\sys\windows\registry (from $GOROOT)
c:\users\admini~1\appdata\local\temp\tmpmpw_zd\gogo\src\golang.org\x\sys\windows\registry (from $GOPATH)

Drop the gabriel-samfira/sys fork
Not needed any more, since we're no longer
tied to Go 1.2.

Fixes https://bugs.launchpad.net/juju/+bug/1470820
Member

axw commented Feb 15, 2017

$$merge$$

Contributor

jujubot commented Feb 15, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 944bc28 into juju:2.1 Feb 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment