Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Replace x/net/websocket with gorilla/websocket. #7013
Conversation
| +// sendInitialErrorV0 writes out the error as a params.ErrorResult serialized | ||
| +// with JSON with a new line character at the end. | ||
| +// | ||
| +// This is a hangover from the initial debug-log streaming endoing where the |
| @@ -341,13 +341,15 @@ func (conn *Conn) input() { | ||
| close(conn.dead) | ||
| } | ||
| +var errRemoteClosed = errors.New("remote closed connection") |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit f06c3e9
into
juju:develop
Feb 22, 2017
pushed a commit
to sinzui/juju
that referenced
this pull request
Feb 23, 2017
added a commit
that referenced
this pull request
Feb 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
howbazaar commentedFeb 21, 2017
There was a tech-board decision some time in the last two years when we were discussing websocket libraries and why we had two. The decision then was to standardise on gorilla/websocket, but nothing happened.
I'm hoping that using the more standards compliant websocket library will help with some of the leaks we are seeing. Even if they don't help right now, the new library gives the client code access to the websocket ping/pong frames, which the old library didn't. This should allow us to have better recognition when the other end goes away.
QA steps
Deploy an old controller, make sure there are workload agents. Upgrade the controller and look at the logs. All older clients, CLI and agents should continue to work as normal. New juju CLI should work with older controller.
Documentation changes
No user impact at all.