migrations (gce): Extract zone name from URL for SetMetadata #7031

Merged
merged 1 commit into from Feb 24, 2017

Conversation

Projects
None yet
3 participants
Member

babbageclunk commented Feb 24, 2017

Description of change

Fix the code that updates the controller tag of machines in the model -
otherwise migrations would fail on GCE. The GCE API requires the
unqualified zone name, so "us-central1-a" rather than:
https://www.googleapis.com/compute/v1/projects/gothic-list-89514/zones/us-central1-a
(Which is what the API gives back to us.)

QA steps

  • Bootstrap 2 GCE controllers, A and B.
  • Add a model to A and deploy an application to it.
  • Migrate model A:m to B.
  • The migration to B should finish successfully and the model should be fully removed from A.
  • Destroying controller A should leave the machines in B:m running.

Bug reference

Fixes https://bugs.launchpad.net/juju/+bug/1667172

Member

babbageclunk commented Feb 24, 2017

Cheers!

$$merge$$

Contributor

jujubot commented Feb 24, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit b1b3f0c into juju:2.1 Feb 24, 2017

@babbageclunk babbageclunk deleted the babbageclunk:mm-gce-adopt-fix branch Feb 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment